prototype: create an entity class out of an excel sheet #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-rew
commented
Oct 5, 2023
Comment on lines
42
to
45
| String fqName = manager.getDefaultNamespace()+"."+dataName; | ||
| if (manager.findDataClass(fqName) != null) { | ||
| throw new RuntimeException("entity "+fqName+" already exists"); | ||
| } |
There was a problem hiding this comment.
you may choose more appropriately how to treat existing classes ... overwrite? delete and forget? ask the user?
ivy-rew
commented
Oct 5, 2023
Comment on lines
106
to
119
| switch (cell.getCellType()) { | ||
| case NUMERIC: | ||
| entity.addField(name, Float.class.getName()); | ||
| break; | ||
| case STRING: | ||
| entity.addField(name, String.class.getName()); | ||
| break; | ||
| case BOOLEAN: | ||
| entity.addField(name, Boolean.class.getName()); | ||
| break; | ||
| default: | ||
| entity.addField(name, String.class.getName()); | ||
| break; | ||
| } |
ivy-rew
commented
Oct 5, 2023
| var name = StringUtils.uncapitalize(names.get(cellNo)); | ||
| switch (cell.getCellType()) { | ||
| case NUMERIC: | ||
| entity.addField(name, Float.class.getName()); |
There was a problem hiding this comment.
maybe on the created field we should also apply some magic: e.g define the max length of the string field or whatever
ivy-rew
commented
Oct 5, 2023
Comment on lines
22
to
31
| void readToEntity(@TempDir Path dir) throws IOException { | ||
| Path path = dir.resolve("customers.xlsx"); | ||
| try(InputStream is = TestEntityClassCreator.class.getResourceAsStream("sample.xlsx")) { | ||
| Files.copy(is, path, StandardCopyOption.REPLACE_EXISTING); | ||
| } | ||
|
|
||
| var reader = new EntityClassReader(); | ||
| var entity = reader.getEntity(path.toFile().toString()); | ||
| assertThat(entity).isNotNull(); | ||
| } |
There was a problem hiding this comment.
run me to create the 'customers' entity out of the given static sample.xlsx
ivy-rew
force-pushed
the
entityCreator
branch
2 times, most recently
from
94606cf to
80a8d0d
Compare
ivy-rew
force-pushed
the
entityCreator
branch
from
80a8d0d to
d9937aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.